[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 3 Mar 2011 15:09:22 +0200 (EET)
From: Julian Anastasov <ja@....bg>
To: David Miller <davem@...emloft.net>
cc: shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [BUG] VPN broken in net-next
Hello,
On Thu, 3 Mar 2011, Julian Anastasov wrote:
> May be the problem is in inet_hash_insert(), it should
> hash ifa_local, not ifa_address. May be they are equal for
... and of course the new __ip_dev_find should use
ifa_local too.
> the common case but not for peer addresses. In devinet_ioctl()
> we can see they are equal initially:
>
> ifa->ifa_address = ifa->ifa_local = sin->sin_addr.s_addr;
>
> but later SIOCSIFDSTADDR can change ifa_address which
> is destination address from the same prefix:
>
> ifa->ifa_address = sin->sin_addr.s_addr;
While checking for ifa_address usage I see other
two places that look suspicious:
- inet_gifconf() exposes address from ifa_local but then
devinet_ioctl() matches by ifa_address in the
'if (tryaddrmatch)' block. I think, we should use ifa_local.
- IN_DEV_ARP_NOTIFY: announces ifa_address instead of ifa_local.
Regards
--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists