netdev - Re: [PATCH] sched: QFQ - quick fair queue scheduler (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Mar 2011 17:03:55 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>,
	Fabio Checconi <fabio@...dalf.sssup.it>,
	Luigi Rizzo <rizzo@....unipi.it>, netdev@...r.kernel.org
Subject: Re: [PATCH] sched: QFQ - quick fair queue scheduler (v2)

Le lundi 28 février 2011 à 17:17 -0800, Stephen Hemminger a écrit :


> +static int qfq_dump_class_stats(struct Qdisc *sch, unsigned long arg,
> +				struct gnet_dump *d)
> +{
> +	struct qfq_class *cl = (struct qfq_class *)arg;
> +	struct tc_qfq_stats xstats;
> +
> +	memset(&xstats, 0, sizeof(xstats));
> +
> +	xstats.weight = ONE_FP/cl->inv_w;
> +	xstats.lmax = cl->lmax;
> +

cl->qdisc->qstats.qlen = cl->qdisc->q.qlen;

> +	if (gnet_stats_copy_basic(d, &cl->bstats) < 0 ||
> +	    gnet_stats_copy_rate_est(d, NULL, &cl->rate_est) < 0 ||
> +	    gnet_stats_copy_queue(d, &cl->qdisc->qstats) < 0)
> +		return -1;
> +
> +	return gnet_stats_copy_app(d, &xstats, sizeof(xstats));
> +}
> +

using 
	gnet_stats_copy_rate_est(d, &cl->bstats, &cl->rate_est) < 0 

is better : We avoid dumping null rate estimation, if admin never asked
a rate estimation...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html