lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 Mar 2011 01:33:43 -0800 From: ebiederm@...ssion.com (Eric W. Biederman) To: David Miller <davem@...emloft.net> Cc: lucian.grijincu@...il.com, adobriyan@...il.com, tavi@...pub.ro, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: RFC v1: sysctl: add sysctl header cookie, share tables between nets David Miller <davem@...emloft.net> writes: > From: Lucian Adrian Grijincu <lucian.grijincu@...il.com> > Date: Fri, 25 Feb 2011 20:52:32 +0200 > >> This is a new approach to the "share sysctl tables" RFC series I >> posted earlier this month. > > I do not disagree conceptually with these changes from a networking > perspective, but I am not a sysctl layer expert so I don't know if the > generic sysctl bits are a good idea or not. I may be missing something in these patches. I haven't had time to look at this most recent batch carefully. But from a 10,000 foot perspective I have a problem with them. With a handful of network devices the size of the data structures is negligible. Where problems show up is when you have a lot of sysctl entries for devices and at that point we have much larger problems using the sysctl data structures. Today add/remove are big O(previous entries) and I think even readdir suffers from non-scalable data structures. There are other related issues that the sysctl data structures are not optimized for use in /proc, and that sysctl uses so usable but on off locking like mechanisms. Changing things to make the sysctl users more dependent on the current implement details of the sysctl data structures seems the exact opposite of the direction we need to go to make the sysctl data structures scale. So until I can see a reason why we should save a few bytes at the cost of greater future maintenance costs I'm not in favor of this patch set. Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists