lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Mar 2011 10:58:40 +0100 From: Jiri Pirko <jpirko@...hat.com> To: Nicolas de Pesloüan <nicolas.2p.debian@...il.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, shemminger@...ux-foundation.org, kaber@...sh.net, fubar@...ibm.com, eric.dumazet@...il.com, andy@...yhouse.net Subject: Re: [patch net-next-2.6 4/8] bonding: wrap slave state work >> >>+static inline void bond_set_active_slave(struct slave *slave) >>+{ >>+ slave->backup = 0; > >In the comment above, you said that the possible value for backup >corresponds with BOND_STATE_ACTIVE and BOND_STATE_BACKUP. > >So, should be: > >slave->backup = BOND_STATE_ACTIVE; > >>+} >>+ >>+static inline void bond_set_backup_slave(struct slave *slave) >>+{ >>+ slave->backup = 1; > >slave->backup = BOND_STATE_BACKUP; > Well, I think it's weird and misleading to assign some define to :1 bitfield. Should be 0 or 1, nothing else. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists