netdev - Re: [PATCH 1/8] Phonet: fix NULL-deref in a8059512b120362b15424f152b2548fe8b11bd0c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2011 22:59:41 +0200
From:	"Rémi Denis-Courmont" <remi@...lab.net>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/8] Phonet: fix NULL-deref in a8059512b120362b15424f152b2548fe8b11bd0c

	Hello,

On March 8th 2011 21:29:23 David Miller, you wrote :
> You don't even read what I tell you, which makes reviewing your work
> insanely frustrating.

Fair enough.

You were the one complaining about the Nokia mail server being insanely 
broken (in private email by the way). So I have to read stuff at home, and 
implement it the next day at work. Informations do get lost at night. I don't 
need to mention I don't like this is frustrating for us Nokians as well.

(...)
> It also irks me that you persisted to provide the most terse possible
> one-line commit message.  Have a conversation in your commit message,
> this isn't for you it's for other people trying to understand your
> work.

I'm trying to fix the terrible mess that ST-Ericsson left of the Phonet stack 
here. This wouldn't be an issue if the crap hadn't been merged, or if I had 
been given enough time to voice my concerns.

Just one WTF? out of many:

        static u8 data[4] = {
                0x03, 0x04,
        };
        data[2] = pn->tx_fc;
        data[3] = pn->rx_fc;

(Those coffee-deprivated, note the 'static' keyword.) I wonder if the guy ever 
wrote C (not C++) before he came to kernel.org and left as quickly.

I am totally fine with strictness on your part. I do genuinely believe it 
improves code quality and such, and do try to apply similar patterns when I am 
the reviewer. So I present my apologizes for my series  of unintended 
violations of The Process.

I just wish you'd been as strict back then. Nobody would be having this 
pointless non-technical discussion... Well... I'll fix it tomorrow because I 
don't want that kind of crap in the Linux kernel anyway.

Thanks every one you for your cooperation.

-- 
Rémi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html