netdev - Re: [Bugme-new] [Bug 30092] New: smsc911x.c drops long packets with VLAN tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2011 10:27:08 +0000
From:	Steve.Glendinning@...c.com
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, bugme-daemon@...zilla.kernel.org,
	bugzilla-daemon@...zilla.kernel.org, netdev@...r.kernel.org,
	weinholt@...net.se, Ian.Saturley@...c.com
Subject: Re: [Bugme-new] [Bug 30092] New: smsc911x.c drops long packets with VLAN
 tags

> > Subject: [PATCH] net/smsc911x.c: Set the VLAN1 register to fix VLAN 
MTU problem
> > From: Göran Weinholt <weinholt@...net.se>
> > 
> > The smsc911x driver would drop frames longer than 1518 bytes, which is 
a
> > problem for networks with VLAN tagging. The VLAN1 tag register is used
> > to increase the legal frame size to 1522 when a VLAN tag is 
identified.
> > 
> > Signed-off-by: Göran Weinholt <weinholt@...net.se>
> 
> Applied, thanks.

Thanks David, I was just about to ack this but you beat me to it :-)

As Göran said, the datasheet is a little vague.  I've checked here, and 
there aren't any bad implications of always turning this option on.

Acked-by: Steve Glendinning <steve.glendinning@...c.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html