netdev - Re: [GIT/PATCH v5] xen network backend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2011 19:30:40 +0000
From:	Ian Campbell <Ian.Campbell@...citrix.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	xen-devel <xen-devel@...ts.xensource.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Francois Romieu <romieu@...zoreil.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	Michał Mirosław <mirqus@...il.com>
Subject: Re: [GIT/PATCH v5] xen network backend driver

On Mon, 2011-03-14 at 18:40 +0000, Ben Hutchings wrote:
> On Mon, 2011-03-14 at 14:27 +0000, Ian Campbell wrote:
> > The following patch is the fifth iteration of the Xen network backend
> > driver for upstream Linux.
> > 
> > This driver ("netback") is the host side counterpart to the frontend
> > driver in drivers/net/xen-netfront.c. The PV protocol is also
> > implemented by frontend drivers in other OSes too, such as the BSDs and
> > even Windows.
> > 
> > Changes since the fourth posting, due to review from Stephen Hemminger:
> >       * Treat dev->features as u32 (it effectively is already and
> >         becomes literally so in net-next -- there's no harm in netback
> >         switching earlier)
> >       * Use stats from struct netdevice instead of a local copy.
> [...]
> 
> All looks good (or good enough) to me.

Thanks.

> I would add Reviewed-by, but this isn't a single patch.

Sure.

> I know you have asked for this to be pulled, in order to retain its
> history, but I'm not sure that David Miller will do this unless the
> driver is at least buildable at each stage in the history.  (However,
> given that the driver wouldn't be enabled before it's added, I'm not
> sure it matters in this case.)

I think it should be, at least from the second commit onwards (modulo
any mistakes made in the past).

To be sure perhaps I should rebase to add a depends BROKEN to (or
otherwise nobble) the Kconfig entry at the beginning of time and only
remove it at the end of the series?

I'd definitely like to keep the cleanups I made while upstreaming
separated from the version imported from xen.git though, but I could
collapse things before that point if that would be preferred. The
upstream/dom0/backend/netback-base branch is the imported version,
everything after that until upstream/dom0/backend/netback is what I
really want to keep as separate commits, the stuff before is just (very)
nice to have.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html