netdev - Re: [PATCH] Disable rp_filter for IPsec packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Mar 2011 15:14:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	msmith@...co.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Disable rp_filter for IPsec packets

From: Michael Smith <msmith@...co.com>
Date: Mon, 14 Mar 2011 18:11:24 -0400

> David Miller wrote:
>> I was trying to get you to think out of the box and come up with
>> something clever, but that isn't working. :-)
> 
> Yes, I got that, but I don't know what you are looking for, and don't
> expect to succeed by trying something else at random.

Existing arguments might be large enough to carry more than one piece
of information :-)

>> In short, fib_validate_source() is nothing but completely unnecessary
>> overhead in the common case.
> 
> I'm not entitled to an opinion about fib_validate_source(). It feels
> like it might be trying to do one too many things. If it were my code
> I might split the RPF out from the spec_dst calculation, move the
> whole lot into net/ipv4/route.c, and only do the fib_lookup() if RPF
> is enabled or CONFIG_IP_ROUTE_CLASSID (i.e. we need to know the itag).

Can't split two two things up, because spec_dst is a product of the
reverse FIB lookup, in the form of FIB_RES_PREFSRC().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html