lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Mar 2011 05:28:23 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Simon Horman <horms@...ge.net.au> Cc: netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org, lvs-devel@...r.kernel.org, Julian Anastasov <ja@....bg>, Hans Schillstrom <hans@...illstrom.com> Subject: Re: [PATCH 02/20] ipvs: reorganize tot_stats Le lundi 14 mars 2011 à 12:45 +0900, Simon Horman a écrit : > From: Julian Anastasov <ja@....bg> > > The global tot_stats contains cpustats field just like the > stats for dest and svc, so better use it to simplify the usage > in estimation_timer. As tot_stats is registered as estimator > we can remove the special ip_vs_read_cpu_stats call for > tot_stats. Fix ip_vs_read_cpu_stats to be called under > stats lock because it is still used as synchronization between > estimation timer and user context (the stats readers). > > Also, make sure ip_vs_stats_percpu_show reads properly > the u64 stats from user context. > > Signed-off-by: Julian Anastasov <ja@....bg> > Signed-off-by: Simon Horman <horms@...ge.net.au> Reviewed-by: Eric Dumazet <eric.dumazet@...il.com> One comment : per cpu stats are really good to avoid cache misses, but I see tot_stats is included in struct netns_ipvs right after "conn_count", possibly sharing a hot cache line ? Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists