netdev - Re: [PATCH] xen: netfront: ethtool stats fields should be unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Mar 2011 04:50:43 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	ian.campbell@...rix.com, netdev@...r.kernel.org, jeremy@...p.org,
	bhutchings@...arflare.com
Subject: Re: [PATCH] xen: netfront: ethtool stats fields should be unsigned
 long

Le lundi 14 mars 2011 à 15:10 -0700, David Miller a écrit :
> From: Ian Campbell <ian.campbell@...rix.com>
> Date: Thu, 10 Mar 2011 17:04:18 +0000
> 
> > Fixup the rx_gso_checksum_fixup field added in e0ce4af920eb to be
> > unsigned long as suggested by Ben Hutchings in
> > <1298919198.2569.14.camel@...-desktop>
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> 
> Applied, thanks Ian.

Hmm, this needs this followup patch then.

Thanks

[PATCH] xen: netfront: fix xennet_get_ethtool_stats()

commit e9a799ea4a5551d2 (xen: netfront: ethtool stats fields should be
unsigned long) made rx_gso_checksum_fixup an unsigned long.

Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
Cc: Ian Campbell <ian.campbell@...rix.com>
Cc: Ben Hutchings <bhutchings@...arflare.com>
---
 drivers/net/xen-netfront.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 27cf72f..5b399b5 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1692,7 +1692,7 @@ static void xennet_get_ethtool_stats(struct net_device *dev,
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(xennet_stats); i++)
-		data[i] = *(int *)(np + xennet_stats[i].offset);
+		data[i] = *(unsigned long *)(np + xennet_stats[i].offset);
 }
 
 static void xennet_get_strings(struct net_device *dev, u32 stringset, u8 * data)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html