netdev - Re: [PATCH] can: c_can: Do basic c_can configuration _before

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2011 18:19:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wg@...ndegger.com
Cc:	jan@...utronix.de, bhupesh.sharma@...com, b.spranger@...utronix.de,
	netdev@...r.kernel.org
Subject: Re: [PATCH] can: c_can: Do basic c_can configuration _before_
 enabling the interrupts

From: Wolfgang Grandegger <wg@...ndegger.com>
Date: Mon, 21 Mar 2011 17:35:45 +0100

> On 03/21/2011 02:47 PM, Jan Altenberg wrote:
>> Hi all,
>> 
>> I ran into some trouble while testing the SocketCAN driver for the BOSCH
>> C_CAN controller. The interface is not correctly initialized, if I put
>> some CAN traffic on the line, _while_ the interface is being started
>> (which means: the interface doesn't come up correcty, if there's some RX
>> traffic while doing 'ifconfig can0 up').
>> 
>> The current implementation enables the controller interrupts _before_
>> doing the basic c_can configuration. I think, this should be done the
>> other way round.
>> 
>> The patch below fixes things for me.
>> 
>> Signed-off-by: Jan Altenberg <jan@...utronix.de>
> 
> Acked-by: Wolfgang Grandegger <wg@...ndegger.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html