netdev - usage of netdev_boot_setup_check() in modern NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 31 Mar 2011 18:41:17 +0200
From:	Domenico Andreoli <cavokz@...il.com>
To:	netdev@...r.kernel.org
Subject: usage of netdev_boot_setup_check() in modern NIC driver

Hi all,

  I'm working on the cs89x0 driver to make it a modern dual ISA/platform
driver (it is used on some non-ISA dev boards, like my QQ2440). Funny
game that could end in nothing except some new learnings for me.

It uses the netdev_boot_setup_check() function to get the configuration
from cmdline. The only other modern ISA driver (isa_(un)register_driver)
which uses it is the 3c509, which seems to invoke and immediately
overwrite part of the values just got.

Since nowdays module params can be set on the cmdline as well, may I
simply dump netdev_boot_setup_check()? It smells of legacy stuff.

In case of multiple NICs, which is the suggested way to pass the
different parameters (irq, iomem, etc) to every card?

Do you agree that such parameters have sense only on the ISA side of
the driver?

Regards,
Domenico

-----[ Domenico Andreoli, aka cavok
 --[ http://www.dandreoli.com/gpgkey.asc
   ---[ 3A0F 2F80 F79C 678A 8936  4FEE 0677 9033 A20E BC50
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html