lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 03 Apr 2011 22:23:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: Allow no-cache copy from user on transmit

From: David Miller <davem@...emloft.net>
Date: Sun, 03 Apr 2011 22:03:05 -0700 (PDT)

> From: Tom Herbert <therbert@...gle.com>
> Date: Sun, 3 Apr 2011 21:56:17 -0700 (PDT)
> 
>> This patch uses __copy_from_user_nocache on transmit to bypass data
>> cache for a performance improvement.  skb_add_data_nocache and
>> skb_copy_to_page_nocache can be called by sendmsg functions to use
>> this feature, initial support is in tcp_sendmsg.  This functionality is
>> configurable per device using ethtool.
>  ...
>> Signed-off-by: Tom Herbert <therbert@...gle.com>
> 
> Applied, thanks Tom.

Actually, I'm sorry, I have to kick this back to you again Tom.

The original problem is that "linux/uaccess.h" has not been included
in the spot where you try to invoke the nocache copies.

linux/uaccess.h, when ARCH_HAS_NOCACHE_UACCESS is defined, provides
dummy routines.

So it's not correct to use ARCH_HAS_NOCACHE_UACCESS to conditionalize
things in the networking, just make sure linux/uaccess.h is included
at the call sites.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists