[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 04 Apr 2011 15:24:19 +0200
From: Patrick McHardy <kaber@...sh.net>
To: David Miller <davem@...emloft.net>
CC: dsterba@...e.cz, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, stable@...nel.org,
Netfilter Development Mailinglist
<netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH] netfilter: h323: bug in parsing of ASN1 SEQOF field
On 23.03.2011 03:33, David Miller wrote:
> From: David Sterba <dsterba@...e.cz>
> Date: Tue, 22 Mar 2011 12:55:29 +0100
>
>> Static analyzer of clang found a dead store which appears to be a bug in
>> reading count of items in SEQOF field, only the lower byte of word is
>> stored. This may lead to corrupted read and communication shutdown.
>>
>> The bug has been in the module since it's first inclusion into linux
>> kernel.
>>
>> Signed-off-by: David Sterba <dsterba@...e.cz>
>
> Please send netfilter patches to the listed netfilter maintainer
> and appropriate mailing lists. I've added them to the CC:
>
> Otherwise your patch will not be looked at by the right people.
>
>> CC: David Miller <davem@...emloft.net>
>> CC: netdev@...r.kernel.org
>> CC: stable@...nel.org
>> ---
>> net/netfilter/nf_conntrack_h323_asn1.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/netfilter/nf_conntrack_h323_asn1.c b/net/netfilter/nf_conntrack_h323_asn1.c
>> index 8678823..bcd5ed6 100644
>> --- a/net/netfilter/nf_conntrack_h323_asn1.c
>> +++ b/net/netfilter/nf_conntrack_h323_asn1.c
>> @@ -631,7 +631,7 @@ static int decode_seqof(bitstr_t *bs, const struct field_t *f,
>> CHECK_BOUND(bs, 2);
>> count = *bs->cur++;
>> count <<= 8;
>> - count = *bs->cur++;
>> + count += *bs->cur++;
>> break;
This looks correct to me. The problem is without practical consequence
though, the largest amount of sequence-of members we parse is 30.
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists