netdev - Re: [PATCH v3] net: Allow no-cache copy from user on transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2011 12:44:08 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: Allow no-cache copy from user on transmit

> I'm simply saying to get rid of the ARCH_HAS_NOCACHE_UACCESS ifdefs
> you're adding to the networking code, since linux/uaccess.h makes sure
> that a nop version of the nocache routines are available always.
>
> If you ifdef the networking bits unnecessarily, those code paths
> won't get build tested in the majority of my test builds, which are
> on sparc64.  So I want to avoid the conditionalized compilation if
> at all possible.
>

I'll take them out, but that will result in one needless conditional
in the transmit path for architectures that don't support the no cache
copy, which seems to be everything except x86!?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html