netdev - Re: [PATCH v2 net-next 3/9] tg3: Reintroduce 5717

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 06 Apr 2011 11:28:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	joe@...ches.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 3/9] tg3: Reintroduce 5717_PLUS

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Wed, 6 Apr 2011 10:33:26 -0700

> For the record though, I did consider using the TG3_FLG3_5717_PLUS flag.
> I'm uncomfortable with using it here because this is more of a server
> class device feature.  Should another mobile or desktop device be
> created in the future, I'd have to devise this type of flag to identify
> what feature I'm really talking about.  I thought it prudent to just
> take care of that now.
> 
> (Not that this is a compelling argument, but it also is a handy way to
> enable and disable the feature while debugging.)

I think the current approach is fine, getting these feature tests right
is indeed non-trivial :-)

I'll apply this patch series to net-next-2.6 and if some tweaks are
still desired, please send them as follow-up patches.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html