lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Apr 2011 18:35:26 -0700 From: Mahesh Bandewar <maheshb@...gle.com> To: Ben Hutchings <bhutchings@...arflare.com> Cc: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH 01/20] net-core: extending (hw_/wanted_/vlan_)features fields to a bitmap. On Tue, Apr 5, 2011 at 6:27 PM, Ben Hutchings <bhutchings@...arflare.com> wrote: > On Tue, 2011-04-05 at 17:44 -0700, Mahesh Bandewar wrote: >> Converting current use of (hw_/wanted_/vlan_)features to >> legacy_(hw_/wanted_/vlan_)features to differntiate from the proposed usage. > [...] >> @@ -1029,44 +1065,51 @@ struct net_device { >> struct list_head napi_list; >> struct list_head unreg_list; >> >> +#define DEV_FEATURE_WORDS 2 >> +#define DEV_FEATURE_BITS (DEV_FEATURE_WORDS*sizeof(long)*BITS_PER_BYTE) >> +#define LEGACY_FEATURE_WORD 0 >> + >> /* currently active device features */ >> - u32 features; >> + unsigned long features; >> /* user-changeable features */ >> - u32 hw_features; >> + DECLARE_BITMAP(hw_feature, DEV_FEATURE_BITS); > [...] > > Sorry, you can't get rid of hw_features without converting all the > callers at the same time. All code has to remain compilable after each > single commit. > I thought I did! My "make allyesconfig; make all" went through. Did I miss something? > Ben. > > -- > Ben Hutchings, Senior Software Engineer, Solarflare > Not speaking for my employer; that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists