lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 08 Apr 2011 15:35:42 -0700 From: Alexander Duyck <alexander.h.duyck@...el.com> To: Ben Hutchings <bhutchings@...arflare.com> CC: "davem@...emloft.net" <davem@...emloft.net>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [net-next-2.6 PATCH 2/2] ethtool: add ntuple flow specifier data to network flow classifier On 4/8/2011 3:21 PM, Ben Hutchings wrote: > On Fri, 2011-04-08 at 15:07 -0700, Alexander Duyck wrote: >> This change is meant to add an ntuple data extensions to the rx network flow >> classification specifiers. The idea is to allow ntuple to be displayed via >> the network flow classification interface. > > Thanks for carrying on with this. > > [...] >> /** >> * struct ethtool_rx_flow_spec - specification for RX flow filter >> * @flow_type: Type of match to perform, e.g. %TCP_V4_FLOW >> * @h_u: Flow fields to match (dependent on @flow_type) >> + * @h_ext: Additional fields to match >> * @m_u: Masks for flow field bits to be ignored >> + * @m_ext: Masks for additional field bits to be ignored. >> + * Note, all additional fields must be ignored unless @flow_type >> + * includes the %FLOW_EXT flag. >> * @ring_cookie: RX ring/queue index to deliver to, or %RX_CLS_FLOW_DISC >> * if packets should be discarded >> * @location: Index of filter in hardware table >> */ >> struct ethtool_rx_flow_spec { >> __u32 flow_type; >> - union { >> - struct ethtool_tcpip4_spec tcp_ip4_spec; >> - struct ethtool_tcpip4_spec udp_ip4_spec; >> - struct ethtool_tcpip4_spec sctp_ip4_spec; >> - struct ethtool_ah_espip4_spec ah_ip4_spec; >> - struct ethtool_ah_espip4_spec esp_ip4_spec; >> - struct ethtool_usrip4_spec usr_ip4_spec; >> - struct ethhdr ether_spec; >> - __u8 hdata[72]; >> - } h_u, m_u; >> + union ethtool_flow_union h_u; >> + struct ethtool_flow_ext h_ext; >> + union ethtool_flow_union m_u; >> + struct ethtool_flow_ext m_ext; >> + __u32 flow_type_ext; > [...] > > You can't add flow_type_ext here. I assume this is an oversight, since > it isn't mentioned anywhere else. > > Ben. > Yeah, I forgot and left it in there. It will be removed and resubmitted. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists