lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Apr 2011 10:46:19 +0300 From: "Vladislav Zolotarov" <vladz@...adcom.com> To: Michał Mirosław <mirq-linux@...e.qmqm.pl> cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Eilon Greenstein" <eilong@...adcom.com> Subject: Re: [PATCH v2] net: bnx2x: convert to hw_features > > In all those cases, bnx2x_reload_if_running() will be called only when > > LRO state is changed while there's a recovery in progress. > > Hmmm... And what about all other features from hw_features? What if they > have changed (in wanted_features) while recovery was in progress? > According to the __netdev_update_features() code it will invoke > ndo_set_features() in these cases either. Do I miss something here? I think I understood what u meant. So, yes, if the bnx2x_nic_load() called only if TPA_ENABLED_FLAG in bp->flags has changed. And this can happen if either NETIF_F_LRO has changed while NETIF_F_RXCSUM was set or if NETIF_F_LRO was set and NETIF_F_RXCSUM is being cleared. thanks, vlad -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists