netdev - Re: [PATCH v2] net: cxgb4{,vf}: convert to hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Apr 2011 01:04:47 +0200
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Dimitris Michailidis <dm@...lsio.com>
Cc:	netdev@...r.kernel.org, Casey Leedom <leedom@...lsio.com>
Subject: Re: [PATCH v2] net: cxgb4{,vf}: convert to hw_features

On Sat, Apr 16, 2011 at 11:23:59AM -0700, Dimitris Michailidis wrote:
> Michał Mirosław wrote:
>> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
>> ---
>> v2: cxgb4: remove now unneeded variable in t4_ethrx_handler()
>>     cxgb4vf: fix hw/vlan_features values
>
> Thanks for doing this.  The cxgb4 part looks good.  For cxgb4vf I have a  
> comment below.
>
>> @@ -2638,19 +2597,18 @@ static int __devinit cxgb4vf_pci_probe(struct pci_dev *pdev,
>> -		netdev->features = (NETIF_F_SG | TSO_FLAGS |
>> -				    NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
>> -				    NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |
>> -				    NETIF_F_GRO);
>> +		netdev->hw_features = NETIF_F_SG | TSO_FLAGS | NETIF_F_RXCSUM |
>> +			NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM;
>> +		netdev->vlan_features = NETIF_F_SG | TSO_FLAGS |
>> +			NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |
>> +			NETIF_F_HW_VLAN_TX | NETIF_F_HIGHDMA;
>
> This NETIF_F_HW_VLAN_TX looks misplaced.  Did you mean to add it to  
> hw_features rather than vlan_features?

Yes. You're right! [v3 following]

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html