netdev - Re: [PATCH 0/42] Kill -Wunused-but-set warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 Apr 2011 20:38:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/42] Kill -Wunused-but-set warnings

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 18 Apr 2011 03:19:15 +0100

> In most of these cases there is presumably no need for the variable at
> all.  In others, the variable should have been used - which I believe is
> the main reason for the warning - and by removing it you will be hiding
> a bug.

If you look at about 5 or 6 of my patches, that's exactly what I did,
make use of the variable.

Otherwise I tossed it.

It seems I messed up the decnet case, which I'll fix shortly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html