lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Apr 2011 15:56:59 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Brian Haley <brian.haley@...com> Cc: Jay Vosburgh <fubar@...ibm.com>, David Miller <davem@...emloft.net>, Andy Gospodarek <andy@...yhouse.net>, Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6 3/3] bonding,ipv4,ipv6,vlan: Handle NETDEV_BONDING_FAILOVER like NETDEV_NOTIFY_PEERS On Mon, 2011-04-18 at 21:32 -0400, Brian Haley wrote: > On 04/18/2011 03:09 PM, Ben Hutchings wrote: > > How about restoring the parameters like this: > > > > --- > > From: Ben Hutchings <bhutchings@...arflare.com> > > Date: Mon, 18 Apr 2011 19:36:48 +0100 > > Subject: [PATCH net-next-2.6] ipv4,ipv6,bonding: Restore control over number of peer notifications > > > > For backward compatibility, we should retain the module parameters and > > sysfs attributes to control the number of peer notifications > > (gratuitous ARPs and unsolicited NAs) sent after bonding failover. > > Also, it is possible for failover to take place even though the new > > active slave does not have link up, and in that case the peer > > notification should be deferred until it does. > > > > Change ipv4 and ipv6 so they do not automatically send peer > > notifications on bonding failover. Change the bonding driver to send > > separate NETDEV_NOTIFY_PEERS notifications when the link is up, as > > many times as requested. Since it does not directly control which > > protocols send notifications, make num_grat_arp and num_unsol_na > > aliases for a single parameter. > > Hi Ben, > > I think this looks good, I'll try and get this tested here when I have > a chance, but for now I can: > > Acked-by: Brian Haley <brian.haley@...com> > > Should we just go ahead and make a new parameter for peer notification? > Compiled but untested patch below. [...] If everyone is in agreement to deprecate the old parameters in favour of a single parameter (or none) I think there should be a target date for removal, documented in Documentation/feature-removal-schedule.txt. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists