netdev - Re: [PATCH] net: forcedeth: fix compile warning of not used nv_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Apr 2011 09:42:15 +0800
From:	Shan Wei <shanwei@...fujitsu.com>
To:	mirq-linux@...e.qmqm.pl, David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: forcedeth: fix compile warning of not used nv_set_tso
 function

This patch is against net-next.

Shan Wei wrote, at 04/20/2011 09:31 AM:
> Fix the below compile warning:
> drivers/net/forcedeth.c:4266: warning: ‘nv_set_tso’ defined but not used
> 
> commit 569e146 converts forcedeth driver to use hw_features.
> So, implement function of .set_tso is abandoned.
> 
> Signed-off-by: Shan Wei <shanwei@...fujitsu.com>
> ---
>  drivers/net/forcedeth.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> index ec9a32d..0e1c76a 100644
> --- a/drivers/net/forcedeth.c
> +++ b/drivers/net/forcedeth.c
> @@ -4263,16 +4263,6 @@ static int nv_nway_reset(struct net_device *dev)
>  	return ret;
>  }
>  
> -static int nv_set_tso(struct net_device *dev, u32 value)
> -{
> -	struct fe_priv *np = netdev_priv(dev);
> -
> -	if ((np->driver_data & DEV_HAS_CHECKSUM))
> -		return ethtool_op_set_tso(dev, value);
> -	else
> -		return -EOPNOTSUPP;
> -}
> -
>  static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring)
>  {
>  	struct fe_priv *np = netdev_priv(dev);


-- 

Best Regards
-----
Shan Wei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html