netdev - Re: [net-next v2 1/6] bnx2x: link report improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 May 2011 23:48:29 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	dmitry@...adcom.com
Cc:	davem@...emloft.net,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eilon Greenstein <eilong@...adcom.com>,
	Vladislav Zolotarov <vladz@...adcom.com>
Subject: Re: [net-next v2 1/6] bnx2x: link report improvements

On Thu, 2011-05-05 at 01:22 +0300, Dmitry Kravkov wrote:
> From: Vladislav Zolotarov <vladz@...adcom.com>
> 
> To avoid link notification duplication
[...]
> --- a/drivers/net/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/bnx2x/bnx2x_cmn.c
> @@ -758,35 +758,120 @@ u16 bnx2x_get_mf_speed(struct bnx2x *bp)
>  	return line_speed;
>  }
>  
> +/**
> + * bnx2x_fill_report_data - fill Link report data according to the current link
> + * configuration.

The kernel-doc format doesn't allow for continuation lines like this.
The short description has to fit on one physical line along with the
function or type name.

Ben.

> + * @bp:		driver handle
> + * @data:	link state to update
> + *
> + * It uses a none-atomic bit operations because is called under the mutex.
> + */
[...]

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html