netdev - Re: [PATCH] hamachi: Delete TX checksumming code commented out since 1999

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 May 2011 09:59:28 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] hamachi: Delete TX checksumming code commented out since 1999

2011/5/6 David Miller <davem@...emloft.net>:
>
> TX checksumming support has been ifdef commented out of this driver
> for more than 10 years, and it makes references to aspects of the IPv4
> stack from back then as well.
>
> If someone has one of these rare cards and wants to properly resurrect
> TX checksumming support, they can still get at this code in the
> version control history.
>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>
> I stumbled over this cruft while auditing ip_queue_xmit() users.
>
>  drivers/net/hamachi.c |   79 -------------------------------------------------
>  1 files changed, 0 insertions(+), 79 deletions(-)
>
> diff --git a/drivers/net/hamachi.c b/drivers/net/hamachi.c
> index 80d25ed..f5fba73 100644
> --- a/drivers/net/hamachi.c
> +++ b/drivers/net/hamachi.c
> @@ -132,14 +132,8 @@ static int tx_params[MAX_UNITS] = {-1, -1, -1, -1, -1, -1, -1, -1};
>  /*
>  * RX_CHECKSUM turns on card-generated receive checksum generation for
>  *   TCP and UDP packets.  Otherwise the upper layers do the calculation.
> - * TX_CHECKSUM won't do anything too useful, even if it works.  There's no
> - *   easy mechanism by which to tell the TCP/UDP stack that it need not
> - *   generate checksums for this device.  But if somebody can find a way
> - *   to get that to work, most of the card work is in here already.
>  * 3/10/1999 Pete Wyckoff <wyckoff@...sandia.gov>
>  */
> -#undef  TX_CHECKSUM
> -#define RX_CHECKSUM

This also disables RX checksumming. You wanted to leave '#define
RX_CHECKSUM' in place?

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html