| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 7 May 2011 18:37:16 -0300 From: Rafael Aquini <aquini@...ux.com> To: Jay Vosburgh <fubar@...ibm.com> Cc: Joe Perches <joe@...ches.com>, kernel-janitors@...r.kernel.org, David Miller <davem@...emloft.net>, Andy Gospodarek <andy@...yhouse.net>, shemminger@...tta.com, netdev@...r.kernel.org, Nicolas Kaiser <nikai@...ai.net> Subject: Re: [PATCH] net/bonding: adjust codingstyle for bond_3ad files Howdy Jay, On Sat, May 07, 2011 at 02:25:41PM -0700, Jay Vosburgh wrote: > My preference would be to only remove the "silence compiler" > comments if the possibility of silent misbehavior is also eliminated. > For __ad_timer_to_ticks, that would mean either a default: case in the > current arrangement, or something like what Joe suggests above. > > If this is beyond the scope of what you, Rafeal, want to do, > that's fine, but in that case leave the "silence" notes in place. Yeah, re-factor that sort of code was beyond my intentions when I first submit the patch. However, it is certainly feasible to be done, and as I wrote before, I'm more than willing to help where is needed to help. I'll review the places where "silence" notes are placed, and try to figure out a proper way to get rid of them. Thank you, folks, for keep hitting me with valuable feedback. Cheers! -- Rafael Aquini <aquini@...ux.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists