netdev - Re: [PATCH v4 1/1] igmp: call ip_mc_clear_src() only when we have no users of ip_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 13:28:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...hat.com
Cc:	dlstevens@...ibm.com, jmorris@...ei.org, kaber@...sh.net,
	kuznet@....inr.ac.ru, linux-kernel@...r.kernel.org, mmarek@...e.cz,
	netdev@...r.kernel.org, netdev-owner@...r.kernel.org,
	pekkas@...core.fi, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH v4 1/1] igmp: call ip_mc_clear_src() only when we have
 no users of ip_mc_list

From: Veaceslav Falico <vfalico@...hat.com>
Date: Tue, 24 May 2011 11:15:05 +0200

> In igmp_group_dropped() we call ip_mc_clear_src(), which resets the number
> of source filters per mulitcast. However, igmp_group_dropped() is also
> called on NETDEV_DOWN, NETDEV_PRE_TYPE_CHANGE and NETDEV_UNREGISTER, which
> means that the group might get added back on NETDEV_UP, NETDEV_REGISTER and
> NETDEV_POST_TYPE_CHANGE respectively, leaving us with broken source
> filters.
> 
> To fix that, we must clear the source filters only when there are no users
> in the ip_mc_list, i.e. in ip_mc_dec_group() and on device destroy.
> 
> Acked-by: David L Stevens <dlstevens@...ibm.com>
> Signed-off-by: Veaceslav Falico <vfalico@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html