netdev - Re: [BUG] net: cpu offline cause napi stall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 14:50:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	heiko.carstens@...ibm.com
Cc:	eric.dumazet@...il.com, blaschka@...ux.vnet.ibm.com,
	netdev@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [BUG] net: cpu offline cause napi stall

From: Heiko Carstens <heiko.carstens@...ibm.com>
Date: Wed, 1 Jun 2011 22:42:34 +0200

> On Wed, Jun 01, 2011 at 10:03:12PM +0200, Eric Dumazet wrote:
>> Le mercredi 01 juin 2011 à 20:12 +0200, Heiko Carstens a écrit :
>> > On Wed, Jun 01, 2011 at 06:55:21PM +0200, Eric Dumazet wrote:
>> > > > +	/* Append NAPI poll list from offline CPU. */
>> > > > +	list_splice_init(&oldsd->poll_list, &sd->poll_list);
>> > > >  
>> > > >  	raise_softirq_irqoff(NET_TX_SOFTIRQ);
>> > > >  	local_irq_enable();
>> > > 
>> > > Please make sure we raise NET_RX_SOFTIRQ on new cpu if necessary.
>> > 
>> > Well, see two lines below the list_splice_init() call ;)
>> 
>> I see nothing... NET_TX_SOFTIRQ and NET_RX_SOFTIRQ are not the same 
> 
> Indeed. I must be blind.

Can I get a final version of this patch with proper commit log message,
signoffs, etc.?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html