[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 05 Jun 2011 22:15:37 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: mst@...hat.com
Cc: maheshb@...gle.com, netdev@...r.kernel.org, therbert@...gle.com,
mirqus@...il.com, shemminger@...tta.com
Subject: Re: [PATCHv3] net: Define enum for the bits used in features.
From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Mon, 6 Jun 2011 06:58:08 +0300
> I've been thinking about this as well. It turns out most
> things above can be done with the spatch (aka coccinelle) tool.
> But I think the largest problem is what to do with multiple-feature
> macros such as NETIF_F_GSO_SOFTWARE.
>
> If we keep them an 'or' of bits, we more or less commit to
> an implementation that can represent them all in a single
> constant.
>
> I played with variadic macros but could not come up with something
> that does not generate a lot of code.
Since the GSO accessors deal with mutliple bits, you can create
special GSO specific interfaces to manipulate them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists