netdev - Re: [PATCHv3] net: Define enum for the bits used in features.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 12:20:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	maheshb@...gle.com, netdev@...r.kernel.org, therbert@...gle.com,
	mirqus@...il.com, shemminger@...tta.com
Subject: Re: [PATCHv3] net: Define enum for the bits used in features.

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Mon, 6 Jun 2011 18:32:53 +0300

> On Sun, Jun 05, 2011 at 10:15:37PM -0700, David Miller wrote:
>> Since the GSO accessors deal with mutliple bits, you can create
>> special GSO specific interfaces to manipulate them.
> 
> Yes but it's not just GSO.
> It's anything that includes more than 1 feature.
> Examples:
> NETIF_F_ALL_CSUM
> NETIF_F_ALL_TX_OFFLOADS
> NETIF_F_V6_CSUM
> NETIF_F_SOFT_FEATURES
> 
> etc
> 
> Creating many accessors for each will need a lot
> of code duplication ...

Yet this is something you must resolve in order to change the feature
bit implementation.

Whether this issue is difficult or not to address, it has to be done
either way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html