lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jun 2011 10:03:14 +0200 From: Daniel Hellstrom <daniel@...sler.com> To: netdev@...r.kernel.org Subject: CRC endianess problem on DGE-510T Hello, I'm having problems with the PCI network board D-LINK DGE-510T on SPARC32/LEON. The CRC calculated by ether_crc_le() does not match the CRC, however after swapping the result it matches. This is the same behaviour with the 3 boards I have. After applying the patch below everything works. Does anyone know if this is a correct patch or has had similar problems on big endian machines? Daniel From: Daniel Hellstrom <daniel@...sler.com> Date: Wed, 6 Apr 2011 15:01:44 +0200 [PATCH] dl2k: EEPROM CRC calculation wrong endianess on bigendian machine Signed-off-by: Daniel Hellstrom <daniel@...sler.com> --- drivers/net/dl2k.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/dl2k.c b/drivers/net/dl2k.c index c445457..4bbbd7b 100644 --- a/drivers/net/dl2k.c +++ b/drivers/net/dl2k.c @@ -346,7 +346,7 @@ parse_eeprom (struct net_device *dev) if (np->pdev->vendor == PCI_VENDOR_ID_DLINK) { /* D-Link Only */ /* Check CRC */ crc = ~ether_crc_le (256 - 4, sromdata); - if (psrom->crc != crc) { + if (psrom->crc != cpu_to_le32(crc)) {q printk (KERN_ERR "%s: EEPROM data CRC error.\n", dev->name); return -1; -- 1.5.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists