netdev - Re: [PATCH 1/1] dl2k: EEPROM CRC calculation wrong endianess on bigendian machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2011 16:54:54 +0200
From:	Daniel Hellstrom <daniel@...sler.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] dl2k: EEPROM CRC calculation wrong endianess on bigendian
 machine

Ben Hutchings wrote:

>On Fri, 2011-06-10 at 15:16 +0200, Daniel Hellstrom wrote:
>  
>
>>Signed-off-by: Daniel Hellstrom <daniel@...sler.com>
>>---
>> drivers/net/dl2k.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>diff --git a/drivers/net/dl2k.c b/drivers/net/dl2k.c
>>index c445457..4bbbd7b 100644
>>--- a/drivers/net/dl2k.c
>>+++ b/drivers/net/dl2k.c
>>@@ -346,7 +346,7 @@ parse_eeprom (struct net_device *dev)
>> 	if (np->pdev->vendor == PCI_VENDOR_ID_DLINK) {	/* D-Link Only */
>> 		/* Check CRC */
>> 		crc = ~ether_crc_le (256 - 4, sromdata);
>>-		if (psrom->crc != crc) {
>>+		if (psrom->crc != cpu_to_le32(crc)) {q
>>    
>>
>
>You still have a rogue 'q' there.
>  
>
ooh, you got a sharp eye, I wonder how that made it into there... I will 
resend, thanks!

Daniel

>Ben.
>
>  
>
>> 			printk (KERN_ERR "%s: EEPROM data CRC error.\n",
>> 					dev->name);
>> 			return -1;
>>    
>>
>
>  
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html