netdev - Re: [PATCH] net/usb: Add Samsung Kalmia driver for Samsung GT-B3730

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Jun 2011 04:46:58 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
Cc:	marius.kotsbak@...il.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, marius@...sbak.com
Subject: Re: [PATCH] net/usb: Add Samsung Kalmia driver for Samsung GT-B3730

On Sat, 2011-06-11 at 16:29 -0700, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Sat, 11 Jun 2011 16:27:11 -0700 (PDT)
> 
> > From: "Marius B. Kotsbak" <marius.kotsbak@...il.com>
> > Date: Sat, 11 Jun 2011 23:55:18 +0200
> > 
> >> Introducing driver for the network port of Samsung Kalmia based USB LTE modems.
> >> It has also an ACM interface that previous patches associates with the "option"
> >> module. To access those interfaces, the modem must first be switched from modem
> >> mode using a tool like usb_modeswitch.
> >> 
> >> As the proprietary protocol has been discovered by watching the MS Windows driver
> >> behavior, there might be errors in the protocol handling, but stable and fast
> >> connection has been established for hours with Norwegian operator NetCom that
> >> distributes this modem with their LTE/4G subscription.
> >> 
> >> More and updated information about how to use this driver is available here:
> >> 
> >> http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?t=465
> >> https://github.com/mkotsbak/Samsung-GT-B3730-linux-driver
> >> 
> >> Signed-off-by: Marius B. Kotsbak <marius@...sbak.com>
> > 
> > Applied, thanks.
> 
> Actually, reverted.
> 
> There's a typo in your Makefile patch, and because of this it
> won't even build the new driver.
[...]

Surely the error is in the Kconfig - the 'CONFIG_' prefix should not be
there.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html