lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2011 10:20:04 -0700 From: Roland Dreier <roland@...estorage.com> To: Bernard Metzler <BMT@...ich.ibm.com> Cc: Bart Van Assche <bvanassche@....org>, linux-rdma@...r.kernel.org, linux-rdma-owner@...r.kernel.org, netdev@...r.kernel.org Subject: Re: software iwarp stack update > I was expecting there is an ib_device->uverbs_cmd_mask > flag which siw does not set... Unfortunately, it is not > completely clear to me when a command mask bit is available > and when the OFA core strictly expects a function pointer. > Maybe there is some redundancy/inconsistency? The uverbs_cmd_mask controls which commands userspace can send down. A kernel consumer does not go through the code that checks this mask. It does seem we are missing an IB_MANDATORY_FUNC entry for modify_port in ib_device_check_mandatory; or on the flip side we are missing a check of modify_port and a -ENOSYS return... I guess modify_port does not really make sense for iWARP so probably the second option is better. - R. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists