netdev - RE: [RFC 2/2] ethtool: Add support for DMA Coalescing feature config to ethtool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Jun 2011 08:50:11 -0700
From:	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>
Subject: RE: [RFC 2/2] ethtool: Add support for DMA Coalescing feature
 config to ethtool.



>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net]
>Sent: Thursday, June 16, 2011 8:34 PM
>To: Wyborny, Carolyn
>Cc: netdev@...r.kernel.org; bhutchings@...arflare.com
>Subject: Re: [RFC 2/2] ethtool: Add support for DMA Coalescing feature
>config to ethtool.
>
>From: Carolyn Wyborny <carolyn.wyborny@...el.com>
>Date: Tue, 14 Jun 2011 10:13:26 -0700
>
>> This RFC patch adds functions to get and set DMA Coalescing feature
>> configuration.
>>
>> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@...el.com>
>
>What in the world is "DMA Coalescing feature", what does it do?
>
>Might it want parameters and not just want to be turned on or off?
>
>This change, at a minimum, needs a more descriptive commit log entry.
>So that other driver authors can understand what exactly the feature
>is and therefore whether they might like to add support for it to
>their drivers.

I will add a fuller description of the feature in my updated patch.  I thought the feature was more well known. Quick description is that it's a power saving feature that causes the adapter to coalesce its DMA writes at low traffic times to save power on the platform by reducing wakeups.  The parameter is intended as a simple u32 value, not just an on or off, but also to allow a variety of configuration by adapter vendors, with validation of the input on the driver side.  Since I left out the implementation in my patch, this wasn't clear.  I will also fix this in my next submission.

Thanks,

Carolyn

Carolyn Wyborny
Linux Development
LAN Access Division
Intel Corporation



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html