lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Jun 2011 15:46:59 +0800 From: Shawn Guo <shawn.guo@...escale.com> To: Grant Likely <grant.likely@...retlab.ca> CC: Shawn Guo <shawn.guo@...aro.org>, <patches@...aro.org>, <netdev@...r.kernel.org>, <devicetree-discuss@...ts.ozlabs.org>, Jason Liu <jason.hui@...aro.org>, <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 2/3] net/fec: add device tree support On Sat, Jun 18, 2011 at 10:22:20AM -0600, Grant Likely wrote: > On Sat, Jun 18, 2011 at 11:19:13PM +0800, Shawn Guo wrote: > > It adds device tree data parsing support for fec driver. > > > > Signed-off-by: Jason Liu <jason.hui@...aro.org> > > Signed-off-by: Shawn Guo <shawn.guo@...aro.org> > > Cc: David S. Miller <davem@...emloft.net> > > --- > > Documentation/devicetree/bindings/net/fsl-fec.txt | 14 ++++++++++ > > drivers/net/fec.c | 28 +++++++++++++++++++++ > > 2 files changed, 42 insertions(+), 0 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/net/fsl-fec.txt > > > > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt > > new file mode 100644 > > index 0000000..705111d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt > > @@ -0,0 +1,14 @@ > > +* Freescale Fast Ethernet Controller (FEC) > > + > > +Required properties: > > +- compatible : should be "fsl,<soc>-fec", "fsl,fec" > > Ditto to comment on last patch. "fsl,fec" is to generic. > "fsl,imx51-soc" should be the generic value. > Ditto to the feedback on the last comment. "fsl,imx51-fec" is not a good one to be the compatibility string for imx27 and imx35 fec. > Otherwise looks okay to me, and I don't see any problem with queueing > it up for v3.1 with that change since it doesn't depend on any other > patches. > > Acked-by: Grant Likely <grant.likely@...retlab.ca> > -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists