netdev - Re: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jun 2011 09:12:34 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	WANG Cong <xiyou.wangcong@...il.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
	davem@...emloft.net, hilld@...arystorm.net
Subject: Re: [PATCH] netconsole: fix build when CONFIG_NETCONSOLE_DYNAMIC is
 turned on

On Tue, 21 Jun 2011 12:50:14 +0000 (UTC) WANG Cong wrote:

> On Mon, 20 Jun 2011 21:25:04 -0700, Randy Dunlap wrote:
> 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > When NETCONSOLE_DYNAMIC=y and CONFIGFS_FS=m, there are build errors in
> > netconsole:
> > 
> > drivers/built-in.o: In function `drop_netconsole_target':
> > netconsole.c:(.text+0x1a100f): undefined reference to `config_item_put'
> > drivers/built-in.o: In function `make_netconsole_target':
> > netconsole.c:(.text+0x1a10b9): undefined reference to
> > `config_item_init_type_name' drivers/built-in.o: In function
> > `write_msg': netconsole.c:(.text+0x1a11a4): undefined reference to
> > `config_item_get' netconsole.c:(.text+0x1a1211): undefined reference to
> > `config_item_put' drivers/built-in.o: In function
> > `netconsole_netdev_event': netconsole.c:(.text+0x1a12cc): undefined
> > reference to `config_item_put' netconsole.c:(.text+0x1a12ec): undefined
> > reference to `config_item_get' netconsole.c:(.text+0x1a1366): undefined
> > reference to `config_item_put' drivers/built-in.o: In function
> > `init_netconsole': netconsole.c:(.init.text+0x953a): undefined reference
> > to `config_group_init' netconsole.c:(.init.text+0x9560): undefined
> > reference to `configfs_register_subsystem' drivers/built-in.o: In
> > function `dynamic_netconsole_exit': netconsole.c:(.exit.text+0x809):
> > undefined reference to `configfs_unregister_subsystem'
> > 
> > so make NETCONSOLE_DYNAMIC require CONFIGFS_FS=y to fix the build
> > errors.
> > 
> > This is one possible fix.
> > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37992
> > 
> > Reported-by: David Hill <hilld@...arystorm.net> Signed-off-by: Randy
> > Dunlap <randy.dunlap@...cle.com> ---
> >  drivers/net/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- lnx-30-rc3.orig/drivers/net/Kconfig +++
> > lnx-30-rc3/drivers/net/Kconfig
> > @@ -3416,7 +3416,7 @@ config NETCONSOLE
> >  
> >  config NETCONSOLE_DYNAMIC
> >  	bool "Dynamic reconfiguration of logging targets"
> > -	depends on NETCONSOLE && SYSFS && CONFIGFS_FS 
> > +	depends on NETCONSOLE
> > && SYSFS && CONFIGFS_FS=y
> 
> I recall someone already fixed this by adding "select CONFIGFS_FS",
> who removed it again... :-/

Hi,

Thanks for the reminder.  I'll try Ben Hutchings' suggestion.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html