netdev - Weird locking in __release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2011 16:31:13 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	netdev@...r.kernel.org
Subject: Weird locking in __release_sock()?

Hi,

In net/core/sock.c the function __release_sock() appears to drop the 
socket lock, and then feed the backlogged skbs to sk_backlog_rcv().

In the case of an IPv4 TCP socket, sk_backlog_rcv() calls 
tcp_v4_do_rcv(), which is documented like this:

/* The socket must have it's spinlock held when we get
  * here.
.
.
.
*/

Q: How can this be correct?

Perhaps I am missing something.  In any event, thanks in advance 
shedding some light on the locking situation.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html