netdev - af-packet tpacket_rcv - why is status flushed before the packet-payload ...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 24 Jun 2011 11:20:35 -0400
From:	chetan loke <loke.chetan@...il.com>
To:	netdev@...r.kernel.org
Subject: af-packet tpacket_rcv - why is status flushed before the
 packet-payload ...

Hi,

in tpacket_rcv() - this is the flushing sequence ...

1)
__packet_set_status(po, h.raw, status);

2)
smp_mb();

3)
#if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE == 1
flush-the-payload
#endif

Why is it done this way?

Shouldn't we be flushing the packet_status after flushing the payload?
So 1 and 3 should be swapped, no?

Chetan Loke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html