netdev - Re: [RFC 54/72] au1000_eth/mipsnet/tc35815: Move the MIPS drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 25 Jun 2011 11:11:21 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Matt Porter <mporter@...nel.crashing.org>,
	Herbert Valerio Riedel <hvr@....org>,
	MontaVista Software <source@...sta.com>,
	Kyle McMartin <kyle@...artin.ca>, Helge Deller <deller@....de>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
	Sam Creasey <sammy@...my.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"linux-m68k@...r.kernel.org" <linux-m68k@...r.kernel.org>
Subject: Re: [RFC 54/72] au1000_eth/mipsnet/tc35815: Move the MIPS drivers

On Sat, 2011-06-25 at 09:13 -0700, Ralf Baechle wrote:
> On Sat, Jun 25, 2011 at 06:59:05AM -0700, Jeff Kirsher wrote:
> 
> > Move the MIPS drivers into drivers/net/ethernet/mips/ and
> > make the necessary Kconfig and Makefile changes.
> 
> NAck.
> 
> sni_82596.c is a driver for the same chip but used in particular
> Siemens-
> Nixdorf systems.  Lasi_82596 is an Intel NIC being used in PARISC
> systems.
> Not a good reason th throw PA-RISC drivers into the same directory
> after
> all PA-RISC has no relation to MIPS at all.  So maybe they should go
> into
> drivers/net/ethernet/i82596 or drivers/net/ethernet/intel.  And
> wherever
> they go, both drivers #include lib82596.c which your patch did not
> move
> around. 

My bad, I had grouped these drivers because they both used lib82596.c
and had thought I had moved that file as well.

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)