netdev - Re: [PATCH] net_sched: fix dequeuer fairness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Jun 2011 11:32:14 -0400
From:	jamal <hadi@...erus.ca>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net_sched: fix dequeuer fairness

On Sun, 2011-06-26 at 17:09 +0200, Eric Dumazet wrote:

> I would just remove the jiffies break, now we have a 64 packets limit...
> 
> if (quota >= work || need_resched()) {
> 	...
> }

Seems reasonable to do. Some stats (on two different machines
at least with dummy) on a system with low # of processes:
~80% of the time - we exit the loop because of packet quota
~1% for both need_resched and jiffy
~19% simply because there were less than quota packets

Note: we do use a jiffy check on net_rx_action() but i suspect
we never ever hit it.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html