netdev - Re: [PATCH 1/2] can: bfin_can: simplify xmit id1 setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jun 2011 09:43:55 +0200
From:	Kurt Van Dijck <kurt.van.dijck@....be>
To:	Mike Frysinger <vapier@...too.org>
Cc:	socketcan-core@...ts.berlios.de,
	Wolfgang Grandegger <wg@...ndegger.com>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 1/2] can: bfin_can: simplify xmit id1 setup

On Fri, Jun 24, 2011 at 10:33:01AM -0400, Mike Frysinger wrote:
> If we look closely, the 4 writes to TRANSMIT_CHL.id1 can be collapsed
> down into much simpler code.  So do just that.
> 
> This also fixes a build failure due to the I/O macros no longer
> getting pulled in.  Their minor (and accidental) usage here gets
> dropped as part of the unification.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>

Nice cleanup.
Acked-by: Kurt Van Dijck <kurt.van.dijck@....be>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html