lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jul 2011 09:25:33 +0200 From: Tobias Klauser <tklauser@...tanz.ch> To: David Miller <davem@...emloft.net> Cc: grundler@...isc-linux.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: de4x5: Omit check for multicast bit in netdev_for_each_mc_addr On 2011-07-01 at 08:57:30 +0200, David Miller <davem@...emloft.net> wrote: > From: Tobias Klauser <tklauser@...tanz.ch> > Date: Wed, 29 Jun 2011 14:16:00 +0200 > > > There is no need to check for the address being a multicast address in > > the netdev_for_each_mc_addr loop, so remove it. > > > > Signed-off-by: Tobias Klauser <tklauser@...tanz.ch> > > Please build test your patches! Sorry for the mess. Here's an updated patch, not removing the addrs local variable. There is no need to check for the address being a multicast address in the netdev_for_each_mc_addr loop, so remove it. Signed-off-by: Tobias Klauser <tklauser@...tanz.ch> --- drivers/net/tulip/de4x5.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c index efaa1d6..d8db2b6 100644 --- a/drivers/net/tulip/de4x5.c +++ b/drivers/net/tulip/de4x5.c @@ -1964,9 +1964,7 @@ SetMulticastFilter(struct net_device *dev) omr |= OMR_PM; /* Pass all multicasts */ } else if (lp->setup_f == HASH_PERF) { /* Hash Filtering */ netdev_for_each_mc_addr(ha, dev) { - addrs = ha->addr; - if ((*addrs & 0x01) == 1) { /* multicast address? */ - crc = ether_crc_le(ETH_ALEN, addrs); + crc = ether_crc_le(ETH_ALEN, ha->addr); hashcode = crc & HASH_BITS; /* hashcode is 9 LSb of CRC */ byte = hashcode >> 3; /* bit[3-8] -> byte in filter */ @@ -1977,7 +1975,6 @@ SetMulticastFilter(struct net_device *dev) byte -= 1; } lp->setup_frame[byte] |= bit; - } } } else { /* Perfect filtering */ netdev_for_each_mc_addr(ha, dev) { -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists