netdev - Re: [PATCH] Disable router anycast address for /127 prefixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 02 Jul 2011 11:38:19 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Brian Haley <brian.haley@...com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Disable router anycast address for /127 prefixes

Brian Haley <brian.haley@...com> writes:
> On 07/01/2011 02:26 PM, Bjørn Mork wrote:
>> Brian Haley <brian.haley@...com> writes:
>>
>>> I'm not sure you'd need this part as there shouldn't be a /127 in the list to remove.
>> 
>> I don't understand exactly what you mean here.... 
>
> If you never add an anycast address when the prefix length is 127, the address
> wouldn't be there when you went to remove it.  In other words, the call to
> __ipv6_dev_ac_dec() would return -ENOENT, which is ignored anyways.

Doh!  Of course.  Sorry for being that slow...

And thanks for taking the time to feed it to me with a small enough
spoon :-)

> It's not a common codepath so the two lines of code wouldn't hurt anything
> I guess...

Personally I prefer "symmetric" coding because it leaves fewer questions
unanswered (necessary for the slow among us, as demonstrated above).

But I think that's for those actually maintaining this code to decide.
I can post an updated patch if required, or feel free to apply only the
first hunk.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html