netdev - Re: [PATCH v2 46/46] net: mark drivers that drop packets from rx queue head under memory pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2011 09:47:08 +0300
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Hartley Sweeten" <hsweeten@...ionengravers.com>,
	"Michael Chan" <mchan@...adcom.com>,
	"Guo-Fu Tseng" <cooldavid@...ldavid.org>,
	"Realtek linux nic maintainers" <nic_swsd@...ltek.com>,
	"Francois Romieu" <romieu@...zoreil.com>,
	"Stephen Hemminger" <shemminger@...ux-foundation.org>,
	"Matthew Carlson" <mcarlson@...adcom.com>,
	"Jon Mason" <jdmason@...zu.us>
Subject: Re: [PATCH v2 46/46] net: mark drivers that drop packets from
 rx queue head under memory pressure

On Sun, 2011-07-10 at 17:52 -0700, Michał Mirosław wrote:
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---

> diff --git a/drivers/net/bnx2x/bnx2x_cmn.c b/drivers/net/bnx2x/bnx2x_cmn.c
> index 4f9164c..a6da01a 100644
> --- a/drivers/net/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/bnx2x/bnx2x_cmn.c
> @@ -673,6 +673,9 @@ int bnx2x_rx_int(struct bnx2x_fastpath *fp, int budget)
>  				goto reuse_rx;
>  			}
>  
> +#warning drops packets from rx queue head on memory pressure
> +#warning (like dev_skb_finish_rx_dma_refill() users)
> +

We have the dropless_fc module parameter that can be configured if the
user prefers pausing on host memory pressure - the problem with that
feature is that it is enough that one of the ring runs out of memory and
the entire port is stopped. When running with 16 rings, this can lead to
serious throughput degradation - this is why it is kept as a user
configurable option.

>  			/* Since we don't have a jumbo ring
>  			 * copy small packets if mtu > 1500
>  			 */



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html