lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jul 2011 14:37:10 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mirq-linux@...e.qmqm.pl Cc: netdev@...r.kernel.org, vladislav.yasevich@...com, sri@...ibm.com, linux-sctp@...r.kernel.org Subject: Re: [PATCH 01/10] net: sctp: fix checksum marking for outgoing packets From: Michaİİ Mirosİİaw <mirq-linux@...e.qmqm.pl> Date: Thu, 14 Jul 2011 02:10:29 +0200 (CEST) > Packets to devices without NETIF_F_SCTP_CSUM (including NETIF_F_NO_CSUM) > should be properly checksummed because the packets can be diverted or > rerouted after construction. This still leaves packets diverted from > NETIF_F_SCTP_CSUM-enabled devices with broken checksums. Fixing this > needs implementing software offload fallback in networking core. > > For users of sctp_checksum_disable, skb->ip_summed should be left as > CHECKSUM_NONE and not CHECKSUM_UNNECESSARY as per include/linux/skbuff.h. > > Signed-off-by: Michaİİ Mirosİİaw <mirq-linux@...e.qmqm.pl> This is not the way to fix this. We need to add the proper software fallback when the SKB device changes to one with SCTP/NO_CSUM to one that does not. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists