lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Jul 2011 20:49:01 -0700 From: Joe Perches <joe@...ches.com> To: Scott Goldman <scottjg@...are.com> Cc: Shreyas Bhatewara <sbhatewara@...are.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "pv-drivers@...are.com" <pv-drivers@...are.com> Subject: RE: [Pv-drivers] [PATCH net-next] vmxnet3: set netdev parant device before calling netdev_info On Wed, 2011-07-20 at 20:06 -0700, Scott Goldman wrote: > > Parent device for netdev should be set before netdev_info() can be called > > otherwise there is a NULL pointer dereference and probe() fails. I believe this is not true. I don't see any NULL pointer dereference here. functions and macros reordered top to bottom. define_netdev_printk_level(netdev_info, KERN_INFO); #define define_netdev_printk_level(func, level) \ int func(const struct net_device *dev, const char *fmt, ...) \ { \ int r; \ struct va_format vaf; \ va_list args; \ \ va_start(args, fmt); \ \ vaf.fmt = fmt; \ vaf.va = &args; \ \ r = __netdev_printk(level, dev, &vaf); \ va_end(args); \ \ return r; \ } \ EXPORT_SYMBOL(func); static int __netdev_printk(const char *level, const struct net_device *dev, struct va_format *vaf) { int r; if (dev && dev->dev.parent) r = dev_printk(level, dev->dev.parent, "%s: %pV", netdev_name(dev), vaf); else if (dev) r = printk("%s%s: %pV", level, netdev_name(dev), vaf); else r = printk("%s(NULL net_device): %pV", level, vaf); return r; } static inline const char *netdev_name(const struct net_device *dev) { if (dev->reg_state != NETREG_REGISTERED) return "(unregistered net_device)"; return dev->name; } -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists