lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Jul 2011 17:37:19 -0700 From: Jay Vosburgh <fubar@...ibm.com> To: Joe Perches <joe@...ches.com> cc: Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6] bonding: reduce noise during init Joe Perches <joe@...ches.com> wrote: >On Tue, 2011-07-26 at 17:35 -0400, Andy Gospodarek wrote: >> Many are using sysfs to configure bonding rather than module options, so >> there is no need for bonding to throw this warning in normal cases. >> Keep the message around when debugging is enabled as it might be useful >> for someone desperate enough to enable debugging, but eliminate it >> otherwise. >[] >> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >[] >> @@ -4745,7 +4745,10 @@ static int bond_check_params(struct bond_params *params) >> /* miimon and arp_interval not set, we need one so things >> * work as expected, see bonding.txt for details >> */ >> - pr_warning("Warning: either miimon or arp_interval and arp_ip_target module parameters must be specified, otherwise bonding will not detect link failures! see bonding.txt for details.\n"); >> + pr_debug("Warning: either miimon or arp_interval and" >> + " arp_ip_target module parameters must be specified," >> + " otherwise bonding will not detect link failures!" >> + " See bonding.txt for details.\n"); > >I'd prefer you don't separate the format string >into multiple pieces. Why not? To me, it looks easier to read split into sections that don't wrap lines. -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists