netdev - Re: [PATCH net-next-2.6] bonding: reduce noise during init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 26 Jul 2011 18:08:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andy Gospodarek <andy@...yhouse.net>
Cc:	netdev@...r.kernel.org, Jay Vosburgh <fubar@...ibm.com>
Subject: Re: [PATCH net-next-2.6] bonding: reduce noise during init

On Tue, 2011-07-26 at 20:56 -0400, Andy Gospodarek wrote:
> On Jul 26, 2011 8:40 PM, "Joe Perches" <joe@...ches.com> wrote:
> > On Tue, 2011-07-26 at 17:37 -0700, Jay Vosburgh wrote:
> > > Joe Perches <joe@...ches.com> wrote:
> > > >I'd prefer you don't separate the format string
> > > >into multiple pieces.
> > > Why not?  To me, it looks easier to read split into sections
> > > that don't wrap lines.
> > Harder to grep for a dmesg and the
> > defect rate of these split formats is
> > typically higher than single strings
> > because of bad spacing between string
> > segments.
> I'll agree that grepping based on dmesg/log output can be more
> difficult, but incorrect spacing should simply be fixed rather than a
> wholesale ban.

I didn't know I can ban things.
Cool.  Do I get a sceptre too?

> The visual benefit when looking at the code makes this really nice, so
> I would prefer to breakup long strings when changing nearby code. 

Up to you.

One other possible benefit of keeping formats
together is that if the message is overly long,
(ideally dmesg should have messages < 80 chars)
then it's more obvious that it should be somehow
shortened.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html