lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Aug 2011 20:20:34 +0800 From: Wang Shaoyan <stufever@...il.com> To: netdev@...r.kernel.org Subject: Re: [PATCH] ATM: Delete no use FILL_RX_POOLS_IN_BH marco applied 2011/7/8 <stufever@...il.com>: > From: Wang Shaoyan <wangshaoyan.pt@...bao.com> > > The macro FILL_RX_POOLS_IN_BH is never been used, in order to avoid > the compiler reports error because of the usage of function INIT_WORK, > we just delete the marco. > > Cc: Chas Williams <chas@....nrl.navy.mil> > Cc: linux-atm-general@...ts.sourceforge.net > Signed-off-by: Wang Shaoyan <wangshaoyan.pt@...bao.com> > --- > drivers/atm/ambassador.c | 11 +---------- > drivers/atm/ambassador.h | 4 ---- > 2 files changed, 1 insertions(+), 14 deletions(-) > > diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c > index a5fcb1e..bb3b016 100644 > --- a/drivers/atm/ambassador.c > +++ b/drivers/atm/ambassador.c > @@ -813,7 +813,7 @@ static void fill_rx_pool (amb_dev * dev, unsigned char pool, > return; > } > > -// top up all RX pools (can also be called as a bottom half) > +// top up all RX pools > static void fill_rx_pools (amb_dev * dev) { > unsigned char pool; > > @@ -872,11 +872,7 @@ static irqreturn_t interrupt_handler(int irq, void *dev_id) { > ++irq_work; > > if (irq_work) { > -#ifdef FILL_RX_POOLS_IN_BH > - schedule_work (&dev->bh); > -#else > fill_rx_pools (dev); > -#endif > > PRINTD (DBG_IRQ, "work done: %u", irq_work); > } else { > @@ -2154,11 +2150,6 @@ static void setup_dev(amb_dev *dev, struct pci_dev *pci_dev) > dev->tx_avail = ATM_OC3_PCR; > dev->rx_avail = ATM_OC3_PCR; > > -#ifdef FILL_RX_POOLS_IN_BH > - // initialise bottom half > - INIT_WORK(&dev->bh, (void (*)(void *)) fill_rx_pools, dev); > -#endif > - > // semaphore for txer/rxer modifications - we cannot use a > // spinlock as the critical region needs to switch processes > mutex_init(&dev->vcc_sf); > diff --git a/drivers/atm/ambassador.h b/drivers/atm/ambassador.h > index bd1c46a..aa97105 100644 > --- a/drivers/atm/ambassador.h > +++ b/drivers/atm/ambassador.h > @@ -630,10 +630,6 @@ struct amb_dev { > u32 iobase; > u32 * membase; > > -#ifdef FILL_RX_POOLS_IN_BH > - struct work_struct bh; > -#endif > - > amb_cq cq; > amb_txq txq; > amb_rxq rxq[NUM_RX_POOLS]; > -- > 1.7.4.1 > > -- Wang Shaoyan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists